Detect incompatible types from incompatible QoS callbacks#436
Open
Detect incompatible types from incompatible QoS callbacks#436
Conversation
Note that this is not hooked up inside of CycloneDDS, so this will never fire currently. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Hunter L. Allen <[email protected]>
eboasson
reviewed
Feb 21, 2023
eboasson
reviewed
Feb 21, 2023
Collaborator
eboasson
left a comment
eboasson
left a comment
There was a problem hiding this comment.
Forgot to mention: other than this one comment on a comment, it looks good to me.
Co-authored-by: eboasson <[email protected]>
clalancette
force-pushed
the
clalancette/inconsistent-topic-event
branch
from
984065a to
6b04608
Compare
Base automatically changed from
clalancette/inconsistent-topic-event
to
rolling
March 13, 2023 13:31
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@clalancette this PR attempts to detect incompatible types from the incompatible QoS callbacks that are already in place.
It's a bit of a hack, and I am not sure how to check it locally (as it seems to depend on some other changes I lack locally), but I think this approach will work.