Skip to content

Add comment not to remove the make multiversion from Dockerfile. #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

fujitatomoya
Copy link
Collaborator

Description

Related to #5595 (comment)

Did you use Generative AI?

No

Additional Information

@fujitatomoya fujitatomoya self-assigned this Jun 25, 2025
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the comment here so that we do not break the documentation pipeline.

@fujitatomoya
Copy link
Collaborator Author

@christophebedard can you take a look? it took me some time to think about why we have make multiversion in the Dockerfile, this prevents us from doing that in the future.

Copy link

github-actions bot commented Jun 25, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/15884901063/artifacts/3404373286.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5756/index.html in your favorite browser

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/add-comment-dockerfile branch from c3ea378 to 9a41b0f Compare June 25, 2025 19:03
@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants