-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Download examples #5840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Download examples #5840
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
28cf699
download examples
InvincibleRMC f888138
Fix lint
InvincibleRMC 20b7d36
Use Path objects like sloretz recommended
InvincibleRMC 525008c
fix unit test
InvincibleRMC c5328fe
allow parents
InvincibleRMC f8df5a9
Merge branch 'rolling' into download_examples
InvincibleRMC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
build/ | ||
_build/ | ||
_downloaded/ | ||
.idea/ | ||
.vscode/ | ||
__pycache__ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright 2025 Open Source Robotics Foundation, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import hashlib | ||
import sys | ||
import pathlib | ||
|
||
# Workaround to be able to import conf without it being a proper module | ||
sys.path.append('..') | ||
|
||
from conf import _hash_file | ||
|
||
def test_hash_file(tmp_path: pathlib.Path) -> None: | ||
non_existent = tmp_path / "does_not_exist.txt" | ||
assert _hash_file(non_existent) == "" | ||
|
||
empty_file = tmp_path / "empty.txt" | ||
empty_file.write_text("") | ||
expected_empty_hash = hashlib.sha256(b"").hexdigest() | ||
assert _hash_file(empty_file) == expected_empty_hash | ||
|
||
content = b"Hello, World!" | ||
known_file = tmp_path / "known.txt" | ||
known_file.write_bytes(content) | ||
expected_known_hash = hashlib.sha256(content).hexdigest() | ||
assert _hash_file(known_file) == expected_known_hash |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be hard to maintain. Ideally, we would create a custom directive (
..
) that takes in the URL to be downloaded and only manage the file/URL/etc. from where it is included in the documentation.