Add XML/YAML launch equivalents for large project tutorial #6021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Sy <[email protected]>
Signed-off-by: Luke Sy <[email protected]>
Update launch_turtlesim_launch.xml to use <let> for passing values in include statements, with a note about earlier launch system version compatibility requiring <arg> instead. Signed-off-by: Luke Sy <[email protected]>
SuperJappie08
left a comment
SuperJappie08
left a comment
There was a problem hiding this comment.
Looks good.
The only possible thing I could find with a (somewhat) quick scan was the missing emphasize lines for turtlesim_world_3_launch.py
|
|
||
| .. literalinclude:: launch/turtlesim_world_3_launch.py | ||
| :language: python | ||
| :emphasize-lines: 12 |
There was a problem hiding this comment.
Maybe add the emphasis to all formats.
Or migrate to push-ros-namespace (with the additional hassle of it currently needing to be explicitly scoped with a group when included).
Contributor
Author
There was a problem hiding this comment.
@SuperJappie08 Thanks for the review!
- Emphasis added to the XML and YAML snippets so all formats highlight the namespace.
- I think we can keep the current approach—“PushROSNamespace” comes later in section 3, and introducing it here in section 2 may disrupt the flow.
SuperJappie08
approved these changes
Nov 27, 2025
SuperJappie08
left a comment
SuperJappie08
left a comment
There was a problem hiding this comment.
Looks good.
I wonder if somewhere it should mention that you can mix launch file types.
(This might not be the place for it, and it might already be mentioned somewhere else; I'm not fully up to date with the documentation improvements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add XML/YAML launch file equivalents "Using ROS 2 Launch For Large Projects" tutorial.
Fixes #6006
Did you use Generative AI?
Partially - Cursor AI Assistant for tutorial rephrasing and refactoring. Each generated line reviewed.
Additional Information
broadcast_listener_launch.pyrenamed tobroadcaster_listener_launch.pyfor correctness for launch file nameTutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.html. If 📝 Replace all trivial launchfile examples with XML/YAML #6006 includes changes totfandurdftutorial, they will be done so in a separate PR.