Skip to content

addTrackedObject Function Fails to Handle Null Pointer, Causing Crash When nullptr is Passed #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

addTrackedObject Function Fails to Handle Null Pointer, Causing Crash When nullptr is Passed #1375

merged 1 commit into from
Apr 4, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 4, 2025 •
edited by christophebedard
Loading

Closes #1373

@ahcorde
addTrackedObject Function Fails to Handle Null Pointer, Causing Crash…
29650dc 
… When nullptr is Passed

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Apr 4, 2025
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 4, 2025

Pulls: #1375
Gist: https://gist.githubusercontent.com/ahcorde/8e74bb2df6612e50a55d478c962b9510/raw/133f1e6029cf874d0c7a444b0526124a3e6b1b4e/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_common
TEST args: --packages-above rviz_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15584

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit a657981 into rolling Apr 4, 2025
2 checks passed
@christophebedard christophebedard deleted the ahcorde/rolling/issue_1373 branch April 4, 2025 19:00
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 4, 2025

https://github.com/Mergifyio backport jazzy humble

@mergify Mergify
Copy link

mergify bot commented Apr 4, 2025 •
edited
Loading

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 4, 2025
@ahcorde @mergify
addTrackedObject Function Fails to Handle Null Pointer, Causing Crash…
9ecee53 
… When nullptr is Passed (#1375)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a657981)
@mergify mergify bot mentioned this pull request Apr 4, 2025
Merged
mergify bot pushed a commit that referenced this pull request Apr 4, 2025
@ahcorde @mergify
addTrackedObject Function Fails to Handle Null Pointer, Causing Crash…
1015e47 
… When nullptr is Passed (#1375)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a657981)
@mergify mergify bot mentioned this pull request Apr 4, 2025
Merged
ahcorde added a commit that referenced this pull request Apr 7, 2025
@mergify @ahcorde
addTrackedObject Function Fails to Handle Null Pointer, Causing Crash…
f15a160 
… When nullptr is Passed (#1375) (#1378)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a657981)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Apr 7, 2025
@mergify @ahcorde
addTrackedObject Function Fails to Handle Null Pointer, Causing Crash…
63afe1a 
… When nullptr is Passed (#1375) (#1379)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit a657981)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addTrackedObject Function Fails to Handle Null Pointer, Causing Crash When nullptr is Passed
2 participants
@ahcorde @christophebedard