Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit panel.focused_border colors to be more visible #14

Merged
merged 3 commits into from
Mar 15, 2025

Conversation

aileks
Copy link
Contributor

@aileks aileks commented Mar 14, 2025

I use keyboard navigation quite a lot within the project panel and the current focus borders make it very hard to tell what I have focused. This was an issue in all three palettes. I chose the "Highlight High" color to fix this for each.

Updated colors:
Rose Pine Example
Rose Pine Moon Example
Rose Pine Dawn Example

@mvllow
Copy link
Member

mvllow commented Mar 14, 2025

If focus is primarily for keyboard navigation, perhaps it should be one of our accent colours, e.g. iris? I'm not sure if zed supports hex transparency but if so then iris at ~20% opacity could be nice (untested).

@t1gu1
Copy link

t1gu1 commented Mar 14, 2025

Way better than what there is actually! (I felt blind navigating with the keyboard in the project panel haha)
Can't wait to get that released update <3

@ThatOneCalculator
Copy link
Member

Could you also edit the template?

@aileks
Copy link
Contributor Author

aileks commented Mar 15, 2025

Could you also edit the template?

Yeah sorry about that.

@ThatOneCalculator
Copy link
Member

If focus is primarily for keyboard navigation, perhaps it should be one of our accent colours, e.g. iris? I'm not sure if zed supports hex transparency but if so then iris at ~20% opacity could be nice (untested).

Yeah, looks much better like that tbh

Unselected
image

Selected
image

@ThatOneCalculator
Copy link
Member

Yeah sorry about that.

Nw :)

@ThatOneCalculator ThatOneCalculator merged commit e07295d into rose-pine:main Mar 15, 2025
@ThatOneCalculator
Copy link
Member

v1.1.3 has been released and PR'd to the zed extensions repo!

zed-industries/extensions#2268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants