feat: add Sandbox support to AgentCardSync controller - #343
Merged
Conversation
The AgentCardSync controller auto-creates AgentCard CRs for workloads with kagenti.io/type=agent and protocol labels. It only watched Deployment and StatefulSet, missing Sandbox workloads entirely. Add ReconcileSandbox method with sandboxReconcilerAdapter following the existing per-kind adapter pattern. Conditionally register a third controller (agentcardsync-sandbox) when the Sandbox CRD is installed. Fixes: #339 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: cwiklik <cwiklikj@gmail.com>
mrsabath
approved these changes
May 8, 2026
mrsabath
left a comment
mrsabath
left a comment
Contributor
There was a problem hiding this comment.
Clean implementation following the existing per-kind adapter pattern. Uses SandboxCRDExists guard for conditional registration, unstructured client for the Sandbox GVK, and correctly checks labels via shouldSyncWorkload before creating AgentCards. RBAC is appropriately read-only.
Areas reviewed: Go (controller logic, adapter pattern, RBAC, manager setup)
CI: All 16 checks pass
github-project-automation
Bot
moved this from Backlog
to Done
in Rossoctl Issue Prioritization
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReconcileSandboxmethod using unstructured client to reconcile Sandbox workloadsagentcardsync-sandbox) withSandboxCRDExists()guardagents.x-k8s.iosandboxesThis ensures AgentCards are auto-created for Sandbox workloads labelled with
kagenti.io/type: agent, making agents discoverable via the A2A protocol.Closes #339
Test plan
agentcardsync-sandboxcontroller registerskagenti.io/type: agent+protocol.kagenti.io/a2a: "true"→ verify AgentCard<name>-sandbox-cardis createdAssisted-By: Claude Code