Skip to content

chore: update dependencies, pin CI actions, add dependabot#390

Merged
pdettori merged 2 commits into
rossoctl:mainfrom
Ladas:fix/dep-updates-ci-pinning
Jun 1, 2026
Merged

chore: update dependencies, pin CI actions, add dependabot#390
pdettori merged 2 commits into
rossoctl:mainfrom
Ladas:fix/dep-updates-ci-pinning

Conversation

@Ladas

@Ladas Ladas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump Go module dependencies to latest versions
  • Pin all GitHub Actions in CI workflows to commit SHA
  • Replace pull_request_target with pull_request in project.yml
  • Add dependabot.yml for automated dependency updates
  • Add security contacts and email to SECURITY.md
  • Quote shell variables in devcontainer post-install.sh

Dependency updates

Package Before After
google.golang.org/grpc v1.67.0 v1.81.1
go.opentelemetry.io/otel v1.28.0 v1.44.0
go.opentelemetry.io/otel/sdk v1.28.0 v1.44.0
golang.org/x/net old v0.55.0
golang.org/x/sys old v0.45.0

Test plan

  • go build ./... passes
  • CI lint and build pass
  • E2E Helm install test passes
  • Unit tests pass (pre-existing envtest failures excluded)

Assisted-By: Claude Code

- Bump Go module dependencies to latest versions:
  google.golang.org/grpc v1.67.0 → v1.81.1,
  go.opentelemetry.io/otel v1.28.0 → v1.44.0,
  go.opentelemetry.io/otel/sdk v1.28.0 → v1.44.0,
  golang.org/x/net → v0.55.0, golang.org/x/sys → v0.45.0

- Pin all GitHub Actions to commit SHA in release.yml,
  project.yml, self-assign.yml, and stale.yaml for
  supply-chain auditability.

- Replace pull_request_target with pull_request in
  project.yml to avoid running with elevated permissions
  on fork PRs.

- Add dependabot.yml for automated GitHub Actions and
  Go module dependency updates.

- Add security contacts and email to SECURITY.md.

- Quote shell variables in devcontainer post-install.sh.

Signed-off-by: Ladislav Smola <lsmola@redhat.com>
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Ladislav Smola <lsmola@redhat.com>
@Ladas
Ladas marked this pull request as ready for review June 1, 2026 15:35
@Ladas
Ladas requested review from a team as code owners June 1, 2026 15:35
Replace individual contact with kagenti-maintainers@googlegroups.com
group email for security reporting.

Signed-off-by: Ladislav Smola <lsmola@redhat.com>
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Ladislav Smola <lsmola@redhat.com>

@pdettori pdettori left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 15 CI checks pass. Changes are clean and well-scoped.

Security improvements confirmed:

  • pull_request_targetpull_request in project.yml correctly removes elevated fork-PR permissions. Note: secrets: inherit won't pass secrets to fork-triggered runs with pull_request — project-board automation will silently skip external contributors' PRs. This is the correct trade-off vs. the original supply-chain risk.
  • All GitHub Actions and reusable workflows pinned to commit SHA with version comments.
  • Trivy scan passes; Dependency Review passes.

Nit (not blocking): Both commits have a duplicate Signed-off-by trailer — the author's sign-off appears twice, sandwiching the Assisted-By line. Likely from git commit -s followed by git rebase --signoff. DCO passes, but a future git rebase -i cleanup would keep the trailers canonical.

Areas reviewed: CI/GitHub Actions, Go modules, Shell scripts, Security, Documentation, Commits
Commits: 2 commits, both signed off (duplicate trailers, non-blocking)
CI status: All passing ✅

@pdettori
pdettori merged commit 405f9a1 into rossoctl:main Jun 1, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from New /:ToDo to Done in Rossoctl Issue Prioritization Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants