Skip to content

fix: fail fast on deployment errors and add action timeout flag #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoavkatz merged 2 commits into from
Jul 16, 2026
Merged

fix: fail fast on deployment errors and add action timeout flag #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ede8a
fix: fail fast on deployment errors and add pyyaml dependency
yoavkatz Jun 28, 2026
4b01eff
feat(deploy-benchmark): add --action-timeout flag and extend MCP wait…
yoavkatz Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions exgentic_a2a_runner/deploy-and-evaluate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ else
"${CLUSTER_FLAG[@]}" \
$MCP_GATEWAY_FLAG \
$LOCAL_IMAGE_FLAG \
|| fail "deploy benchmark failed"
|| fail "Benchmark deployment failed (step 1/3)"

echo ""
echo "✓ Benchmark deployed successfully"
Expand Down Expand Up @@ -326,7 +326,7 @@ else
$MCP_GATEWAY_FLAG \
$LOCAL_IMAGE_FLAG \
"${PLUGIN_FLAGS[@]}" \
|| fail "deploy agent failed"
|| fail "Agent deployment failed (step 2/3)"

echo ""
echo "✓ Agent deployed successfully"
Expand Down Expand Up @@ -370,7 +370,7 @@ else
fi

"$SCRIPT_DIR/evaluate-benchmark.sh" "${EVALUATE_ARGS[@]}" \
|| fail "evaluate failed"
|| fail "Evaluation failed (step 3/3)"
fi

if [ "$DRY_RUN" = "true" ]; then
Expand Down
16 changes: 15 additions & 1 deletion exgentic_a2a_runner/deploy-benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ BENCHMARK_NAME=""
USE_MCP_GATEWAY="false"
USE_LOCAL_IMAGE="false"
CLUSTER_MODE=""
ACTION_TIMEOUT="1000"

# Parse arguments
while [[ $# -gt 0 ]]; do
Expand Down Expand Up @@ -43,6 +44,10 @@ while [[ $# -gt 0 ]]; do
USE_LOCAL_IMAGE="true"
shift
;;
--action-timeout)
ACTION_TIMEOUT="$2"
shift 2
;;
--kind)
CLUSTER_MODE="kind"
shift
Expand All @@ -64,6 +69,7 @@ while [[ $# -gt 0 ]]; do
echo ""
echo "Optional Arguments:"
echo " --model MODEL Model name (default: Azure/gpt-4.1)"
echo " --action-timeout SECONDS Per-action step timeout in seconds (default: 30)"
echo " --keycloak-user USER Keycloak username (default: admin)"
echo " --keycloak-pass PASS Keycloak password (auto-detected from cluster if not provided)"
echo " --use-mcp-gateway Register MCP server with the MCP Gateway"
Expand Down Expand Up @@ -420,6 +426,11 @@ if [[ "$BENCHMARK_NAME" == "gsm8k" ]]; then
ENV_VARS=$(echo "$ENV_VARS" | jq ". + [{\"name\": \"EXGENTIC_SET_BENCHMARK_RUNNER\", \"value\": \"direct\"}]")
fi

if [ -n "$ACTION_TIMEOUT" ]; then
echo "Adding EXGENTIC_SET_BENCHMARK_ACTION_TIMEOUT=$ACTION_TIMEOUT"
ENV_VARS=$(echo "$ENV_VARS" | jq ". + [{\"name\": \"EXGENTIC_SET_BENCHMARK_ACTION_TIMEOUT\", \"value\": \"$ACTION_TIMEOUT\"}]")
fi

echo "✓ Environment variables prepared for deployment"
echo ""

Expand Down Expand Up @@ -513,7 +524,7 @@ MCP_URL="$(tool_http_url "$TOOL_NAME" "$NAMESPACE")"
echo " MCP URL: $MCP_URL"

MCP_READY=false
MCP_MAX_WAIT=180
MCP_MAX_WAIT=300
for i in $(seq 1 $MCP_MAX_WAIT); do
MCP_HTTP_CODE=$(curl -s -o /tmp/mcp_health_response.txt -w "%{http_code}" --max-time 3 \
-X POST "$MCP_URL/mcp" \
Expand Down Expand Up @@ -672,6 +683,9 @@ echo "Benchmark configuration:"
echo " Deployment: $TOOL_NAME"
echo " Namespace: $NAMESPACE"
echo " Model: $MODEL_NAME"
if [ -n "$ACTION_TIMEOUT" ]; then
echo " Action Timeout: ${ACTION_TIMEOUT}s"
fi
if [ -n "$OPENAI_API_BASE" ]; then
echo " Memory Limit: 3Gi"
echo " OPENAI_API_BASE: $OPENAI_API_BASE"
Expand Down