Skip to content

Reclassify critical assembler warnings as errors #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxrcy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reclassify critical assembler warnings as errors #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
434e31a
feat: promote incorrect operand count warning to error
dxrcy Sep 30, 2025
768d282
feat: promote unexpected psuedo-op warning to error
dxrcy Sep 30, 2025
cb6cdb8
feat: promote invalid token before `.ORIG` warning to error
dxrcy Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/assemble.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ uint16_t preorig (filearr_t f, uint32_t *ln, arrs_t *arrs)
warning (i, "'%s' is only used in project mode", token[0]->str);
break;
default:
warning (i, "Ignoring invalid token '%s' before '.ORIG'",
error (i, "Invalid token '%s' before '.ORIG'",
token[0]->str);
break;
}
Expand Down Expand Up @@ -216,7 +216,7 @@ uint8_t passone (uint32_t ln, uint16_t *addr, TokenBuffer *buf, arrs_t *arrs)
} else if (pop == FILL) {
*addr += 1;
} else {
warning (ln, "Ignoring unexpected use of '%s' in program body",
error (ln, "Unexpected use of '%s' in program body",
token[j]->str);
}
} else if (isregister (token[j]) >= 0) {
Expand All @@ -238,7 +238,7 @@ uint8_t passone (uint32_t ln, uint16_t *addr, TokenBuffer *buf, arrs_t *arrs)
if (opnum == -1) {

} else if (opcount > opnum) {
warning (ln, "'%s' expects %d operands", tok, opnum);
error (ln, "'%s' expects %d operands", tok, opnum);
} else if (opcount < opnum) {
error (ln, "'%s' expects %d operands", tok, opnum);
}
Expand Down Expand Up @@ -526,7 +526,7 @@ uint8_t passtwo (uint32_t tbufind, uint16_t *addr, arrs_t *arrs)
case IMPORT:
if (isproject ()) break;
default:
warning (ln, "Ignoring unexpected use of '%s' in program body",
error (ln, "Unexpected use of '%s' in program body",
token[0]->str);
break;
}
Expand Down