Add condition to CMP0148 cmake_policy - #135
Merged
ppisar merged 2 commits intoOct 14, 2025
Merged
Conversation
ppisar
reviewed
Oct 13, 2025
ppisar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. It looks good. Could you please correct the indentation?
ppisar
force-pushed
the
fix-cmake-el-cmp0148
branch
from
October 14, 2025 13:15
8a71b2d to
3e6bd14
Compare
ppisar
approved these changes
Oct 14, 2025
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of #119 make it hard to not say impossible to build libcomps 0.1.23 without having to manually patch the
libcomps/CMakeLists.txtfile on CS9, on CentosStream9 we have cmake 3.26.5, this version does not support CPM0148.Without this patch we get the following error: