-
Notifications
You must be signed in to change notification settings - Fork 427
Revert "restore global settings function" #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Revert "restore global settings function" #123
Conversation
This reverts commit e5424ce.
this will be a major (breaking) change: version bump to 3.x? |
This. Getting rid of that function broke a project I'm working on, and the new "solution" breaks the project even more. |
@TheEssemCraft This PR is a breaking change, not a fix for a breaking change. Perhaps your issue is addressed by #130 ? |
Hi Team, |
That's just a TypeScript problem. Nothing to do with angular |
Also you should make a new issue and not hijack other threads |
Sorry guys |
Co-Authored-By: Christopher Carman <[email protected]>
Thomas Grainger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This reverts commit e5424ce.