-
Notifications
You must be signed in to change notification settings - Fork 12
Add actypes:activities for external package activities #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ffc92a7
to
96f1be1
Compare
96f1be1
to
097ff0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at this, I am not sure we need it. The activities package should provide the actions we need as autoloads. Then we can create activities with <activities-new ...> and restore them with <activities-resume ...> buttons. If you have an idea of some other syntax to use to recognize activities names implicitly, let me know.
You think the actype is to simple? It is a tiny wrapper because the package lacks a function to resume an activity from its name but we could provide that ourselves or ask the author to provide one. That would also solve the issue I'm having with whether the activity should be resumed from the last state or if it should reset to the default state. Since with <..> notation parameters can be provided. I guess it is a balance. The lispy notation with arrow brackets allows users to create their own buttons but requires them to know about what functions to use. With a defact it will be listed on button creation and documented. Activities is special in that it is an external package so gets into that problem as well. Much to think about here.
Haven't thought about it in that way. Will sleep on it! |
I would suggest first asking alphapapa to add the missing function that you need to the package. I like the idea of making activities easy to use with Hyperbole. |
Yes. I'm on it. 🙏 I've been using my own functions with for action-buttons with activities for a couple of days and it works fine. What do you think is the criteria for pointing users to use action-buttons rather than Hyperbole providing support through explicit buttons? What was previously available only through ebuts can now be done with labeled ibuts and action-buttons (abuts?)!? |
@rswgnu This is the PR on activities: alphapapa/activities.el#149 |
What
Add actypes:activity for the external package activities.
Why
It is convenient so switch between activities using global buttons or
per project ebuts.
Notes
This is work in progress.
WDYT?
external packages?
Related: Would be nice to be able to use the assist key for getting
activity with the default state. But for ebuts as for ibuts the assist
key invokes help. With current scheme we would have to prompt user on
creation and have two types of buttons. With and without state
reset. Ideas?
This is a PR in Draft mode for the discussion.