Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/web flash #2

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix/web flash #2

merged 2 commits into from
May 15, 2024

Conversation

KuraZuzu
Copy link
Collaborator

@KuraZuzu KuraZuzu commented May 14, 2024

What does this implement/fix?

M5StackCoreS3の書き込みが失敗するissueの原因の一部を修正。

Does this close any currently open issues?

こちらのissueが対象になりますが、クローズにはしません。

web書き込みまでテストするには、gha-pagesブランチを作成した上でGitHubPagesの設定を行う必要があります。

How has this been tested?

ししかわ版スタックチャンの既知の不具合で修正されたPRの変更点のみを取り込んだ後、CIに通るように修正しました。

npm run formatでフォーマットの修正点を確認

$ npm run format

> [email protected] format
> prettier --check stackchan/{,**/}*.ts ./mods/**/*.js

Checking formatting...
[warn] stackchan/drivers/dynamixel-driver.ts
[warn] Code style issues found in the above file. Forgot to run Prettier?

npm run format:fixでフォーマットを修正

$ npm run format:fix

> [email protected] format:fix
> prettier --write stackchan/{,**/}*.ts mods/**/*.js

フォーマットの修正完了を確認

$ npm run format

> [email protected] format
> prettier --check stackchan/{,**/}*.ts ./mods/**/*.js

Checking formatting...
All matched files use Prettier code style!

GitHub上でCIが通ることを確認しました。

Any other comments?

Checklists

Copy link
Contributor

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@KuraZuzu KuraZuzu merged commit ea8ed8b into main May 15, 2024
2 checks passed
@KuraZuzu KuraZuzu deleted the fix/web-flash branch May 17, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants