-
Notifications
You must be signed in to change notification settings - Fork 149
Evalg 84 #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xFrenchy
wants to merge
8
commits into
rticommunity:master
Choose a base branch
from
xFrenchy:EVALG-84
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−12
Open
Evalg 84 #711
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bf4bef9
Change polling period to 5 seconds instead of an hour and a half
ea3ce76
Merge branch 'rticommunity:master' into master
xFrenchy 5544f58
Updating Dockerfile and cmake for Debian package
b5b3961
Reverting unrelated change
1507ef1
decoupling the docker steps into two files
43a4659
PR feedback
1be6e54
Removing duplicate copy of NDDSHOME
53491a6
Removing unneeded copy
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,25 @@ | ||
| FROM rticom/connext-sdk:7.3.0-EAR as build-stage | ||
|
|
||
| # For armv8 uncomment the following line | ||
| # ENV CONNEXTDDS_ARCH=armv8Linux4gcc7.3.0 | ||
|
|
||
| FROM connext-sdk:latest as build-stage | ||
| WORKDIR /app | ||
|
|
||
| # Copy the necessary files to the container | ||
| COPY rti_license.dat ${NDDSHOME} | ||
| COPY CMakeLists.txt . | ||
| COPY home_automation.idl . | ||
| COPY *.cxx . | ||
| COPY *.xml . | ||
| COPY *.cxx ./ | ||
| COPY *.xml ./ | ||
|
|
||
| # Build the applications | ||
| RUN apt-get install -y cmake | ||
| RUN mkdir build | ||
| WORKDIR /app/build | ||
| RUN cmake .. | ||
| RUN cmake .. -DCONNEXTDDS_DIR=/opt/rti.com/rti_connext_dds-7.3.0/ | ||
alexcamposruiz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| RUN make -j4 | ||
|
|
||
| # Copy the built applications to a new container | ||
| FROM rticom/connext-runtime:7.3.0-EAR as final-stage | ||
| FROM connext-sdk:latest as final-stage | ||
|
|
||
| WORKDIR /app | ||
| COPY --chown=rtiuser:rtigroup --from=build-stage ${NDDSHOME}/rti_license.dat ${NDDSHOME} | ||
| COPY --chown=rtiuser:rtigroup --from=build-stage /app/build/ /app | ||
| COPY *.xml /app | ||
| COPY --from=connext-sdk /opt/rti.com/rti_connext_dds-7.3.0/rti_license.dat ./ | ||
| COPY --from=build-stage /app/build/ ./ | ||
| COPY *.xml ./ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| FROM ubuntu:20.04 as build-stage | ||
|
|
||
| ARG RTI_LICENSE_AGREEMENT_ACCEPTED=false | ||
|
|
||
| # Install the required packages | ||
| RUN export DEBIAN_FRONTEND=noninteractive \ | ||
| && apt-get update \ | ||
| && apt-get install -y \ | ||
| build-essential \ | ||
| cmake \ | ||
| curl \ | ||
| git \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists | ||
|
|
||
| # Install prerequisites | ||
| RUN curl -sSL -o /usr/share/keyrings/rti-official-archive.gpg \ | ||
| https://packages.rti.com/deb/official/repo.key | ||
| RUN printf -- "deb [arch=%s, signed-by=%s] %s %s main\n" \ | ||
| $(dpkg --print-architecture) \ | ||
| /usr/share/keyrings/rti-official-archive.gpg \ | ||
| https://packages.rti.com/deb/official \ | ||
| $(. /etc/os-release && echo ${VERSION_CODENAME}) | \ | ||
| tee /etc/apt/sources.list.d/rti-official.list >/dev/null | ||
|
|
||
| # Install the RTI Connext Debian Package | ||
| RUN export DEBIAN_FRONTEND=noninteractive \ | ||
| RTI_LICENSE_AGREEMENT_ACCEPTED=${RTI_LICENSE_AGREEMENT_ACCEPTED} \ | ||
| && apt-get update \ | ||
| && apt-get install -y rti-connext-dds-7.3.0 \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists | ||
|
|
||
| COPY rti_license.dat /opt/rti.com/rti_connext_dds-7.3.0/ | ||
| RUN git clone --recurse-submodule https://github.com/rticommunity/rticonnextdds-examples.git |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to figure out the right CONNEXTDDS_ARCH based on the system's archicteure (for ex. with
uname -m)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this on armv8, this comment was leftover from how the file was before. If everything else looks good, I'll test this part in the lab to see if setting CONNEXTDDS_ARCH is needed and if so, using uname -m or some other cpu command