Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An early commit for feedback before I go down the wrong path. :)
An early code review to keep me from going too far down the wrong track.
Some background:
The user will be told in the hands-on to run codegen to get project files/type files to work with this application. (I'll be adding the Subscriber side next when this code looks reasonable).
The user will be told in the hands-on to edit the Topic names, and the data being written
I know the Application is under-commented, but hopefully the intent is clear.
I'll be working on the Subscriber side next, and moving from Listeners to using a WaitSet.
Also: Should we have javadoc comments before each class and method?