Skip to content

Add ruby 3.4 to CI #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2025
Merged

Add ruby 3.4 to CI #438

merged 3 commits into from
May 31, 2025

Conversation

hakeem0114
Copy link
Contributor

No description provided.

@hakeem0114
Copy link
Contributor Author

@HarlemSquirrel Could you take a quick look at this MR?

HarlemSquirrel
HarlemSquirrel reviewed May 15, 2025
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this! There's a little more to do here

.github/workflows/test.yml
@@ -23,6 +23,7 @@ jobs:
- "3.1"
- "3.2"
- "3.3"
- "3.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add a ci-3.4 service to the docker-compose.yml

HarlemSquirrel
HarlemSquirrel approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel merged commit 990a666 into ruby-ldap:master May 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hakeem0114 @HarlemSquirrel