ORDER BY and value comparison fixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…criterion was taken into account) and the order for missing values, blank nodes, IRIs and literals
|
I've e-mailed the waiver to the [email protected] mailing list. |
gkellogg
added a commit
that referenced
this pull request
Jul 27, 2014
ORDER BY and value comparison fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue #15 from the original sparql project repository, only the first ORDER BY criterion was taken into account. Also, there was no predefined order between blank nodes, IRIs and literal values (or lack thereof) as described in the SPARQL recommendation.
I've fixed both issues and written some non-regression tests for them. I've also updated a MIME type in a Unit Test (change necessary with the latest version of the rdf-turtle library).
To sum up: