Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use test task of Rake instead for testing #240

Closed
wants to merge 1 commit into from
Closed

Conversation

gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Feb 7, 2025

  • Rakefile: Use TestTask of Rake; remains "test" task and now accepts TEST environment variable and so on.
  • test/run.rb: Removed file.
  • .github/workflows/test.yml (gem): Updated to utilize Rake's test task instead of the deleted run.rb script.

* Rakefile: Use TestTask of Rake; remains "test" task and now accepts TEST
environment variable and so on.
* test/run.rb: Removed file.
* .github/workflows/test.yml (gem): Updated to utilize Rake's test task
instead of the deleted "run.rb" script.
@kou
Copy link
Member

kou commented Feb 7, 2025

I don't like Rake::TestTask because it's inconvenient. For example, we can't pass arguments via command line arguments (test/run.rb -t /TargetTest/). We need to use environment variable (rake test TESTOPTS="-t /TargetTest/", rake test TEST=test/XXX.rb) instead.

@gemmaro
Copy link
Contributor Author

gemmaro commented Feb 7, 2025

Thank you for sharing your thoughts! I agree that using the existing script is better. I'll close this issue thread.

@gemmaro gemmaro closed this Feb 7, 2025
@gemmaro gemmaro deleted the test branch February 7, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants