Merged learning hour form partial. #5389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iverick
requested review from
compwron,
FireLemons and
littleforest
as code owners
Iverick
force-pushed
the
merge_learning_hours_form_partial
branch
from
e17b0ae to
9fb1b82
Compare
There was a problem hiding this comment.
@Iverick this looks great! It doesn’t look like we have any learning_hours system specs in place though. Would you mind adding some? The spec/system/hearing_types/new_spec.rb would be a good one to copy to spec/system/learning_types/new_spec.rb and modifying, and then you could also create spec/system/learning_hours/edit_spec.rb which would be somewhat similar.
Iverick
force-pushed
the
merge_learning_hours_form_partial
branch
3 times, most recently
from
42a5f37 to
c6dc60f
Compare
|
Updated PR to add system tests for learning hours |
littleforest
approved these changes
Nov 22, 2023
…r learning_hours.
Iverick
force-pushed
the
merge_learning_hours_form_partial
branch
from
c6dc60f to
d20d4c1
Compare
|
All right, I rebased this branch on the latest version of main to resolve conflicts and updated PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5372
What changed, and why?
Modified learning_hours controller and views to use single form partial. Removed update_form partial.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9