Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine tuning for metric chart #5405

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Fine tuning for metric chart #5405

merged 8 commits into from
Nov 24, 2023

Conversation

FireLemons
Copy link
Collaborator

@FireLemons FireLemons commented Nov 24, 2023 •
edited
Loading

What changed, and why?

  • Formatting graph data is faster
  • All hours and days are visible
  • Titled the graph, removed chart labels from below the chart and in the legend.
  • Removed the legend because there's only one dataset and clicking it disabled the only dataset
  • Errors are shown to the user via the notifier component

How is this tested? (please write tests!) 💖💪

Manually

Screenshots please :)

Old:
image
image

New:
image

@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code erb labels Nov 24, 2023
@FireLemons FireLemons merged commit 9dc36fe into rubyforgood:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@littleforest littleforest Awaiting requested review from littleforest

Assignees
No one assigned
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FireLemons