updates Procfile.dev to use dev js and css build scripts #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion from yarn to npm
alex-yi37
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
alex-yi37
changed the title
compwron
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
N/A
What changed, and why?
After the PR to migrate from
yarntonpmwas merged, I noticed that runningbin/devlocally no longer seemed to start the dev server for me and exited immediately. Also saw that a CI check started failing, and it seemed related.I changed the scripts in
Procfile.devto make use of thedevversions for building js and css and this seemed to fix the issue. Still not entirely sure why the switch fromyarntonpmmattered here. This is a bit out of my wheelhouse, so not sure if I missed anything important. Please let me know if anything seems off!How is this tested? (please write tests!) 💖💪
Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
The extent of my testing here was to ensure that running
bin/devstarted the dev server successfully and watched for js and css assets being rebuilt. Also making sure that the previously failing CI step started passing.I did try building the app with Docker locally as part of these instructions but it would hang at a certain step (
docker compose build) so I just gave up on it for now.Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
Trying to run bin/dev before changes results exits and does not start the dev server locally
Trying to run bin/dev after changes starts the dev server successfully
Example PR with failing Docker CI step
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
