Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs to ensure there are no "double reported" advisories. #585

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spec/advisories_spec.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
require 'spec_helper'
require 'gem_advisory_example'
require 'ruby_advisory_example'
require 'advisory_dir_example'

describe "gems" do
Dir.glob(File.join(ROOT,'gems/*/*')) do |path|
include_examples 'Gem Advisory', path
end

Dir.glob(File.join(File.dirname(__FILE__), '../gems/*')) do |dir|
include_examples 'Advisory Directory', dir
end

let(:dir) { File.join(ROOT,'gems') }
let(:advisory_dirs) { Dir.glob('*', base: dir) }

Expand All @@ -31,4 +36,8 @@
Dir.glob(File.join(ROOT, 'rubies/*/*')) do |path|
include_examples 'Rubies Advisory', path
end

Dir.glob(File.join(File.dirname(__FILE__), '../rubies/*')) do |dir|
include_examples 'Advisory Directory', dir
end
end
27 changes: 27 additions & 0 deletions spec/advisory_dir_example.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
require 'rspec'
require 'date'

shared_examples_for "Advisory Directory" do |dir|
describe dir do
let(:advisory_paths) { Dir.glob(File.join(dir,'*.yml')) }
let(:advisories) do
advisory_paths.map do |path|
YAML.safe_load_file(path, permitted_classes: [Date])
end
end

it "must not contain duplicate CVE IDs" do
cve_ids = advisories.map { |advisory| advisory['cve'] }
cve_ids.compact!

expect(cve_ids).to eq(cve_ids.uniq)
end

it "must not contain duplicate GHSA IDs" do
ghsa_ids = advisories.map { |advisory| advisory['ghsa'] }.compact
ghsa_ids.compact!

expect(ghsa_ids).to eq(ghsa_ids.uniq)
end
end
end