Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patched version for CVE-2013-1656 #702

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add patched version for CVE-2013-1656 #702

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9aef0b6
Add patched version for CVE-2013-1656
Aug 29, 2023
fc8ae7e
Update related urls for CVE-2013-1656
Aug 29, 2023
ba2e7e7
Update related urls for CVE-2013-1656
Aug 29, 2023
8853492
Update related urls for CVE-2013-1656
Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gems/spree/CVE-2013-1656.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ patched_versions:
related:
url:
- https://spreecommerce.com/blog/multiple-security-vulnerabilities-fixed
- https://github.com/spree/spree/commit/70092eb55b8be8fe5d21a7658b62da658612fba7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- https://github.com/spree/spree/commit/70092eb55b8be8fe5d21a7658b62da658612fba7
- https://github.com/spree/spree/commit/70092eb55b8be8fe5d21a7658b62da658612fba7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your editor is automatically adding the newline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v0lck3r GitHub isn't allowing me to use the Suggested change. GitHub is claiming there is no difference between them, even though it's supposed to remove the last newline.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@postmodern yeah I have no idea why is that !

Copy link
Author

@oussama-rahali oussama-rahali Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@postmodern tbh I see no extra line. the file is still 25 lines total after adding the new reference, compared to the 24 lines in the original file .
Can you double check please !