Conversation
| } | ||
| } | ||
|
|
||
| #[allow(clippy::too_many_arguments)] |
Contributor
There was a problem hiding this comment.
Lol oh no. Good to know :p
Member
Author
There was a problem hiding this comment.
Yeah the baseline for clippy is max 7 arguments: I find it both kind of funny and really awesome that Rust is so opinionated to even have a limit on the number of parameters enforced in their linter
logan-markewich
approved these changes
Feb 16, 2026
Contributor
logan-markewich
left a comment
logan-markewich
left a comment
There was a problem hiding this comment.
This looks good to me! Also looks a tad annoying to drill down the option to everything lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--workspaceoption to commands involving a workspace to avoid having to set it through env variable.Option<&str>as workspace name