fix(output): preserve directory structure in output (fix issue #13)#25
Open
smhagit wants to merge 1 commit intorunegan:masterfrom
Open
fix(output): preserve directory structure in output (fix issue #13)#25smhagit wants to merge 1 commit intorunegan:masterfrom
smhagit wants to merge 1 commit intorunegan:masterfrom
Conversation
…n#13) Change-Id: Ic6da54ffac9ce8e19e63a6a08d63858079f434d1
Owner
|
Great job! Thank you! I haven't been able to test the new functionality, but it seems to be backwards compatible at least. Could you write one or two tests for it in "test.js", where it tests if it creates the desired output with an input? And testing it with "npm test" I'm also trying to keep the code uniform, on smhagit-preserve-structure I've run eslint to apply the styling. So it would be great if you could merge with that. Hope that is doable. Thank you for the pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new parameter to preserve the output directory structure (if the input is a directory).
The new
preserveStructureparameter defaults tofalseto don't break any existing CI/CD scripts which rely on the previous (put all in one directory) behaviour.I bumped the version from 2.2.0 to 2.3.0.
This resolves issue #13