Update consumable-cooldowns to 1.3.1 #9437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CopyPastaOSRS
commented
Nov 6, 2025
CopyPastaOSRS
commented
- Update item ID names for crab meat which changed with the sailing update
- Small README update
|
|
|
Internal use only: Reviewer details Maintainer details |
Member
|
FYI, we recommend updating your ItemID references to use gamevals.ItemID instead, as those names will never change with game updates. This would prevent your plugin from needing updates in tandem with game updates which change item names. |
Contributor
|
I submitted a PR to your repo to use gamevals. Note that this game update still would have broken your plugin as the gameval for COOKED_GIANT_CRAB_MEAT did indeed change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.