update cpu and gpu type generators #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also changes the gh url
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rachfop
previously approved these changes
Feb 20, 2025
Co-authored-by: Mo King <[email protected]>
also changes the gh url
|
alright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these files, that basically do the same thing, were entirely different - even outputting their tables in different formats.
this pr migrates both files to use pandas and tabulate. i've kept the same sort key, but somehow the sorting changes dramatically anyway.
updating the cpu types file in this way also improves our search presence, as this table being api response key names isn't very pretty
finally,
i unwrapped the code from a try/catch in favor of
raise_for_status()