Enable sccache for windows runners when enabled#32
Open
AdamGS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
changed the title
Author
|
I wasn't sure if I should include the binaries, LMK what to do about them |
AdamGS
commented
Mar 27, 2026
| echo "RUSTC_WRAPPER: $RUSTC_WRAPPER" | ||
|
|
||
| test-sccache-windows: | ||
| runs-on: runs-on=${{ github.run_id }}/cpu=2/family=m7/image=windows25-full-x64/extras=s3-cache |
Author
There was a problem hiding this comment.
had to use windows25 here because it seems like the sccache action assumes some stuff about the powershell env that aren't true for the windows22 images
Contributor
There was a problem hiding this comment.
yes, windows25 is the future-proof image, I'll probably deprecate windows22 soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31.
Enables sccache on Windows runners when applicable. Includes a test that verifies it actually works. In my latest run it dropped build time from 56s to 35s, cache hit rate is just under 90%.