Implement parsing & resolving lnurls #2
Conversation
| @@ -944,6 +947,38 @@ impl PaymentInstructions { | |||
| )) | |||
| }, | |||
| } | |||
| } else if let Some((_, data)) = | |||
There was a problem hiding this comment.
Isn't this supposed to support decoding any part of the string that contains lnurl* rather than only if the full string is lnurl*? I saw a checkout not long ago that used a QR code to display, eg https://a.website/to-visit?lnurl=lnurlasdfwerqwer so that users who just scan the QR code go to their website but if a wallet scans it it will resolve the lnurl.
| @@ -111,10 +111,14 @@ pub trait HrnResolver { | |||
| /// can be further parsed as payment instructions. | |||
| fn resolve_hrn<'a>(&'a self, hrn: &'a HumanReadableName) -> HrnResolutionFuture<'a>; | |||
|
|
|||
| /// Resolves the given Lnurl into a [`HrnResolution`] containing a result which | |||
There was a problem hiding this comment.
An Lnurl isn't a well-defined thing, I believe? This needs to specify what, exactly, the url parameter is (a URL for an LNURL endpoint, and not the encoded LNURL...... strings).
| @@ -111,10 +111,14 @@ pub trait HrnResolver { | |||
| /// can be further parsed as payment instructions. | |||
| fn resolve_hrn<'a>(&'a self, hrn: &'a HumanReadableName) -> HrnResolutionFuture<'a>; | |||
|
|
|||
| /// Resolves the given Lnurl into a [`HrnResolution`] containing a result which | |||
| /// can be further parsed as payment instructions. | |||
| fn resolve_lnurl<'a>(&'a self, url: &'a str) -> HrnResolutionFuture<'a>; | |||
There was a problem hiding this comment.
Should we rename the trait now that its resolving more than HRNs? I think I'm fine with no, because we really want this to be about HRNs, we just happen to support LNURL too, but still.
No description provided.