Skip to content

Verify modelled vs no model matches #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tcharding opened this issue May 2, 2025 · 0 comments
Open

Verify modelled vs no model matches #144

tcharding opened this issue May 2, 2025 · 0 comments

Comments

@tcharding
Copy link
Member

After #142 merges add logic to verify to check that Method::new_modelled matches 'version + model' in 'Returns' section and that Method::new_no_model matches with 'version'.
tcharding added a commit to tcharding/corepc that referenced this issue May 2, 2025
@tcharding
types: Improve the version specific SSOT docs
4946066 
The module docs in each version specific module (e.g. `types::v17`) are
supposed to be the single source of truth for devs trying to work out
which methods are supported and how.

Make an effort to better present the information.

Note that a bunch docs for methods marked as TODO may be incorrect re
version vs version + model. This doesn't matter right now since they
will be checked when implemented and also TODO implies no guarantees (in
my mind anyway).

Note also issue rust-bitcoin#144. `verify` does not check the Returns column against
the `Method` constructor type.

Close: rust-bitcoin#109
This was referenced May 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tcharding