-
Notifications
You must be signed in to change notification settings - Fork 32
Implement savemempool method and test #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d386c0
to
e012e7d
Compare
For methods that return Null I don't think we need to add a type. We can just use an integration test to prove the return is null. If Core later changes the test will catch it. Then we change the 'Returns' column to 'returns nothing'. For reference see |
Once we have a few of these merged I'd say you'll have the idea and then you can just smash out a bunch at a time. Good to iron out the strategy first though with these simple PRs, saves work in the long run, well done. |
Aright, Noted... |
True... |
7d2a55a
to
1299e34
Compare
Hey mate, when I merge PRs in this repo I use the Bitcoin Core merge script. And because of that if there are mentions (using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super happy with this man, the new return in v23 is exactly why this work is useful. Nice to have found success on the second try (after pruneblock).
Alright. Sorry for that... |
No stress! |
Hey mate, if you think of it. When you force push can you post a quick message saying either what the force push is or what the status of the PR is. Otherwise I have to check out the branch, context switch into this PR, then work out if my last review suggestions were seen to etc - this all takes brain power, of which I only have a limited amount. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 565702f
True, I will start doing that now... |
The JSON-RPC method
savemempool
returns a null. We would like to test this in case a later version of Core changes this behaviour.This PR adds a client function that errors if the return value is anything other than
null
, along with an integration test that calls this function.Ref: #116