Skip to content

types: Improve the version specific SSOT docs #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
303 changes: 156 additions & 147 deletions types/src/v17/mod.rs

Large diffs are not rendered by default.

312 changes: 158 additions & 154 deletions types/src/v18/mod.rs

Large diffs are not rendered by default.

311 changes: 160 additions & 151 deletions types/src/v19/mod.rs

Large diffs are not rendered by default.

313 changes: 161 additions & 152 deletions types/src/v20/mod.rs

Large diffs are not rendered by default.

325 changes: 167 additions & 158 deletions types/src/v21/mod.rs

Large diffs are not rendered by default.

335 changes: 172 additions & 163 deletions types/src/v22/mod.rs

Large diffs are not rendered by default.

333 changes: 171 additions & 162 deletions types/src/v23/mod.rs

Large diffs are not rendered by default.

341 changes: 175 additions & 166 deletions types/src/v24/mod.rs

Large diffs are not rendered by default.

343 changes: 176 additions & 167 deletions types/src/v25/mod.rs

Large diffs are not rendered by default.

359 changes: 184 additions & 175 deletions types/src/v26/mod.rs

Large diffs are not rendered by default.

359 changes: 184 additions & 175 deletions types/src/v27/mod.rs

Large diffs are not rendered by default.

363 changes: 186 additions & 177 deletions types/src/v28/mod.rs

Large diffs are not rendered by default.

30 changes: 21 additions & 9 deletions verify/src/versioned.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,31 @@ pub fn methods_and_status(version: Version) -> Result<Vec<Method>> {
.with_context(|| format!("Failed to grep rustdocs in {}", path.display()))?;
let reader = io::BufReader::new(file);

// let re = Regex::new(r"\/\/\! \| ([a-z]+) \| ([.*?]) \|").unwrap();
let re = Regex::new(r"\/\/\! \| ([a-z]+) .* \| ([a-z ()]+?) \|").unwrap();
let re = Regex::new(r"\/\/\! \| ([a-z]+) .* \| ([a-z +]+?) \|.*\|").unwrap();

let mut methods = Vec::new();

for line in reader.lines() {
let line = line?;

let override_status = if line.contains("UNTESTED") {
Some(Status::Untested)
} else if line.contains("TODO") {
Some(Status::Todo)
} else {
None
};

if let Some(caps) = re.captures(&line) {
let name = caps.get(1).unwrap().as_str();
let status = caps.get(2).unwrap().as_str();
let status = status.trim().parse::<Status>()?;
methods.push(Method { name: name.to_string(), status });
let method_name = caps.get(1).unwrap().as_str();
let returns_column = caps.get(2).unwrap().as_str();

let status = match override_status {
Some(status) => status,
None => returns_column.trim().parse::<Status>()?,
};

methods.push(Method { name: method_name.to_string(), status });
}
}
Ok(methods)
Expand Down Expand Up @@ -122,10 +134,10 @@ impl FromStr for Status {

fn from_str(s: &str) -> Result<Self, Self::Err> {
match s {
"done" => Ok(Status::Done),
"version" => Ok(Status::Done),
"version + model" => Ok(Status::Done),
"omitted" => Ok(Status::Omitted),
"done (untested)" => Ok(Status::Untested),
"todo" => Ok(Status::Todo),
"returns nothing" | "returns numeric" | "returns boolean" | "returns string"=> Ok(Status::Done),
other => Err(anyhow::Error::msg(format!("unknown status: '{}'", other))),
}
}
Expand Down