Skip to content

Implement importprunedfunds and test #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

GideonBature
Copy link
Contributor

The JSON-RPC method importprunedfunds does not return anything. We want to test this to catch any changes in behavior in future Core versions.

This PR adds a client function that errors if the return value is anything other than null, along with an integration test that calls this function.

Ref: #116

@GideonBature
Copy link
Contributor Author

Suggested changes implemented. Thank you @jamillambert.

@tcharding
Copy link
Member

Hey mate, in a case like this the formatting could be part of the first patch. The reason I asked you to do the formatting changes separately is when adding a type to the re-exports formatting sometimes moves a ton of lines that are hard to review. I'll merge as is though, just letting you know for next time. Keep at it man, you are killing it.

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4eef869

@tcharding tcharding merged commit 414ba10 into rust-bitcoin:master Jun 24, 2025
29 checks passed
@GideonBature
Copy link
Contributor Author

Hey mate, in a case like this the formatting could be part of the first patch. The reason I asked you to do the formatting changes separately is when adding a type to the re-exports formatting sometimes moves a ton of lines that are hard to review. I'll merge as is though, just letting you know for next time. Keep at it man, you are killing it.

Noted. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants