Implement settxfee method and test #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
reviewed
Jul 7, 2025
| () => { | ||
| impl Client { | ||
| pub fn set_tx_fee(&self, fee_rate: bitcoin::FeeRate) -> Result<SetTxFee> { | ||
| let fee_rate_btc_kvb = fee_rate.to_sat_per_vb_floor() as f64 / 100_000.0; |
There was a problem hiding this comment.
This is correct and drinks on me because you found an API hole in rust-bitcoin. See rust-bitcoin/rust-bitcoin#4688 if you are interested.
tcharding
reviewed
Jul 7, 2025
| #[test] | ||
| fn wallet__set_tx_fee() { | ||
| let node = Node::with_wallet(Wallet::Default, &[]); | ||
| let fee_rate = FeeRate::from_sat_per_vb(2).expect("fee_rate"); |
There was a problem hiding this comment.
Since you have to rebase anyways can you change this to
Suggested change
| let fee_rate = FeeRate::from_sat_per_vb(2).expect("fee_rate"); | |
| let fee_rate = FeeRate::from_sat_per_vb(2).expect("2 sat/vb is valid"); |
The idea being the expect message is basically a comment to those reading the code and is never going to be hit at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
settxfeedoes return a type. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than the type it returns, along with an integration test that calls this function.
Ref: #116