This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Do a bunch of minor improvements #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BlockHash` type is 32 bytes and implements `Copy`, we should pass it by value not by reference.
Convert `Option<Result<T, E>>` to ``Result<Option<T>, E>` by using the `transpose` combinator - TIL.
The `v17::GetNetworkInfo` does not have connections in and out, only total. We should not have these fields until we support a version of Core that does have these fields.
This is kruft from an earlier design; currently we only support v17 `sendtoaddress` which only responds with the txid.
This is indeed the correct way to get `collect` to transform a list of `Result<T, E>` to a `Result<Vec<T>, E>`.
The integration tests will catch this if it is wrong.
We want to provide all shapes of JSON data so having two explicit functions is a reasonable way, I can't think of a better one right now.
I may have got mixed up with `getblockchaininfo` when I wrote this FIXME, we only support v17 `getnetworkinfo` and the `warnings` field is correctly named (and documented).
Investigate and remove the fixme, leave a more terse comment incase someone stumbles upon this later.
This code is verbose but trivial, lets leave it in.
tcharding
force-pushed
the
06-09-improve
branch
from
2465bd4 to
e14093a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
FIXMEs and things like that, non of this is controversial.