Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10.x backport #707

Merged
merged 5 commits into from
Jul 14, 2024
Merged

10.x backport #707

merged 5 commits into from
Jul 14, 2024

Conversation

sanket1729
Copy link
Member

No description provided.

@sanket1729
Copy link
Member Author

sanket1729 commented Jul 12, 2024 •
edited
Loading

@apoelstra. We had lots of CI fixes particularly for fuzz fixes, strict dead code errors. Is it possible to locally test the package and cut a release?

Same question for another 11.x PR

@apoelstra
Copy link
Member

Yep, I will locally test things.

@apoelstra
Copy link
Member

The MSRV on this old version is 1.41.1. Your use of the matches! macro breaks it. Can you change the unit test?

@sanket1729
Copy link
Member Author

@apoelstra changed this. Can you try testing again

apoelstra
apoelstra approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a4576ae

@apoelstra
Copy link
Member

apoelstra commented Jul 14, 2024 •
edited
Loading

I think it's good now. The CI setup on this old version is pretty weird in a few ways (different MSRV for std vs nostd, unstable feature that requires nightly) so I am not 100% certain. But after reading the diff and doing some spot-checks and running my local CI on it and determining that failures are "expected", I think we're good to go. Will merge and release. I was able to tweak my local CI setup to work with these old versions and get (fairly large) feature matrix coverage and MSRV coverage.

@apoelstra apoelstra merged commit 43c3d22 into rust-bitcoin:release-10.x Jul 14, 2024
1 of 17 checks passed
@apoelstra
Copy link
Member

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanket1729 @apoelstra