key: don't use Hasher to generate fingerprints; just use hashes crate
#726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2024-08--no-hasher
branch
from
85949c7 to
5e62ce4
Compare
|
conceptACK. You missed setting the PR title. |
apoelstra
force-pushed
the
2024-08--no-hasher
branch
from
5e62ce4 to
0dedcec
Compare
apoelstra
changed the title
Hasher to generate fingerprints; just use hashes crate
There is no need to hash up the secret for Keypair. It already has a "fingerprint" in the form of its public key. We should just use that.
apoelstra
force-pushed
the
2024-08--no-hasher
branch
from
0dedcec to
b8ac971
Compare
|
CI failure looks like some unrelated |
Kixunil
approved these changes
Aug 26, 2024
| fn fmt(&self, f: &mut ::core::fmt::Formatter) -> ::core::fmt::Result { | ||
| f.debug_struct("Keypair") | ||
| .field("pubkey", &self.public_key()) | ||
| .field("secret", &"<hidden>") |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…erate fingerprints; just use `hashes` crate b8ac97174541b8341b67f8566d64406154b6c5e4 keypair: use public key for Debug output (Andrew Poelstra) a16e5ecd49a994fd32fe69bcf0666a654ae66581 secret keys: debug output only when `hashes` is enabled (Andrew Poelstra) Pull request description: In addition to changing `SecretKey` and `SharedSecret` to use `hashes`, we also unconditionally use the public half of `KeyPair` as a fingerprint, since that's always available and does not need extra deps. This patches the existing unit tests but doesn't add more. Maybe they should be removed; it's a bit weird to have unit tests for `Debug` output. But in this case we're doing some nontrivial logic and I guess we wanted to double-check that it was taking effect. I'd also like to change the manual tagged-hash implementation to use `bitcoin_hashes` methods but those are under construction rust-bitcoin/rust-bitcoin#3184 and the existing stuff is neither faster nor less code than what's currently done. So we'll live with it. Fixes #725 ACKs for top commit: Kixunil: ACK b8ac97174541b8341b67f8566d64406154b6c5e4 Tree-SHA512: d0a65e0a0069bcbc663c1d3e7f98b75868355c4db48e9a9c905cdcd2af1606ac86090cdf0aae5caa23337c5d565e6420d7c956dd0a65a1877004840075bc08e9
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…erate fingerprints; just use `hashes` crate b8ac97174541b8341b67f8566d64406154b6c5e4 keypair: use public key for Debug output (Andrew Poelstra) a16e5ecd49a994fd32fe69bcf0666a654ae66581 secret keys: debug output only when `hashes` is enabled (Andrew Poelstra) Pull request description: In addition to changing `SecretKey` and `SharedSecret` to use `hashes`, we also unconditionally use the public half of `KeyPair` as a fingerprint, since that's always available and does not need extra deps. This patches the existing unit tests but doesn't add more. Maybe they should be removed; it's a bit weird to have unit tests for `Debug` output. But in this case we're doing some nontrivial logic and I guess we wanted to double-check that it was taking effect. I'd also like to change the manual tagged-hash implementation to use `bitcoin_hashes` methods but those are under construction rust-bitcoin/rust-bitcoin#3184 and the existing stuff is neither faster nor less code than what's currently done. So we'll live with it. Fixes #725 ACKs for top commit: Kixunil: ACK b8ac97174541b8341b67f8566d64406154b6c5e4 Tree-SHA512: d0a65e0a0069bcbc663c1d3e7f98b75868355c4db48e9a9c905cdcd2af1606ac86090cdf0aae5caa23337c5d565e6420d7c956dd0a65a1877004840075bc08e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to changing
SecretKeyandSharedSecretto usehashes, we also unconditionally use the public half ofKeyPairas a fingerprint, since that's always available and does not need extra deps.This patches the existing unit tests but doesn't add more. Maybe they should be removed; it's a bit weird to have unit tests for
Debugoutput. But in this case we're doing some nontrivial logic and I guess we wanted to double-check that it was taking effect.I'd also like to change the manual tagged-hash implementation to use
bitcoin_hashesmethods but those are under construction rust-bitcoin/rust-bitcoin#3184 and the existing stuff is neither faster nor less code than what's currently done. So we'll live with it.Fixes #725