Skip to content

Conversation

thejpster
Copy link
Contributor

Makes sure that we're generating FPU code correctly. Prints a nice ASCII art sine wave to standard out, using f32 and f64.

Makes sure that we're generating FPU code correctly. Prints a nice
ASCII art sine wave to standard out, using f32 and f64.
Copy link
Contributor

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found a nit, should libm be optional as with gic, or should gic no longer be optional for the examples?

arm-gic = { version = "0.7.1", optional = true }
critical-section = "1.2.0"
heapless = "0.9.1"
libm = "0.2.15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be optional as with gic?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was thinking about that feature. For the examples I'm inclined to make the GIC crate mandatory and remove the feature. If you don't want to use the GIC, don't use it. I don't know it makes the examples better if they show how to make your interrupt controller optional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was in the cortex-ar crate then yeah, totally should be optional.

Copy link
Contributor

@korken89 korken89 Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I mean examples are not really held by SemVer anyways. I think easy running of examples triumphs 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But lets take that in another PR, I can help out with that small thing. :)

cortex-a-rt = { path = "../../cortex-a-rt" }
cortex-r-rt = { path = "../../cortex-r-rt" }
semihosting = { version = "0.1.18", features = ["stdio"] }
libm = "0.2.15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants