Skip to content

riscv-types: use #[non_exhaustive] and implement core::error::Error for result::Error #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

riscv-types: use #[non_exhaustive] and implement core::error::Error for result::Error #363

wants to merge 3 commits into from
+11 −2

Conversation

@romancardenas
Copy link
Contributor

@romancardenas romancardenas commented Nov 3, 2025

These changes align riscv-types with cortex-m-types

@romancardenas romancardenas requested a review from a team as a code owner November 3, 2025 17:50
rmsyn
rmsyn previously approved these changes Nov 9, 2025
View reviewed changes
Copy link
Contributor

@rmsyn rmsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romancardenas
Copy link
Contributor Author

romancardenas commented Nov 10, 2025

Ther were conflicts, so a second review will be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmsyn rmsyn rmsyn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romancardenas @rmsyn