Skip to content

Fix typo in return type of dynx Future's O-generic vtable #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielhenrymantilla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in return type of dynx Future's O-generic vtable #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions explainer/async_fn_in_dyn_trait/generalizing_from_box_to_dynx.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ struct FutureVtable<O> {
///
/// Unsafe condition: Expects the output from `IntoRawPointer::into_raw`
/// which must not have already been freed.
poll_fn: unsafe fn(*mut (), cx: &mut Context<'_>) -> Ready<()>,
poll_fn: unsafe fn(*mut (), cx: &mut Context<'_>) -> Ready<O>,

/// Frees the memory for the pointer to future.
///
Expand Down Expand Up @@ -176,4 +176,4 @@ impl<O> Drop for dynx Future<Output = O> {
}
}
}
```
```
Copy link
Author

@danielhenrymantilla danielhenrymantilla Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Hmm, I made this PR from the web UI; I don't really know what the change on this line is about 😅