Make cargo-bisect-rustc work with hyphen or space
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Dec 31, 2024
| // `cargo bisect-rustc` (with a space) to work identically. | ||
| if let Some(command) = os_args.get(1) { | ||
| if command == "bisect-rustc" { | ||
| os_args.remove(1); |
There was a problem hiding this comment.
Weird that we don't need to adjust arg 0 to show "the right" (whatever that means) command. The output seems to look right
oli-obk
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the executable name
cargo-bisect-rustc(with a hyphen) works the same ascargo bisect-rustc(with a space). This fixes parsing problems when used with a space as demonstrated in #359.Previously, cbr would try to support both forms, but it didn't always work (see #359). This is due to the way it was trying to do a fallback parsing without the subcommand, which means CLI parsing errors when used as a subcommand to not work (since the original error was discarded).
The solution is to not attempt to use clap to do subcommand handling, and instead just strip the
bisect-rustcsubcommand if it exists.Other than fixing the errors, one observable change is that
cargo-bisect-rustc(without a space, with no arguments) will now behave the same ascargo bisect-rustc(it will start the bisection process). Previously it would print a somewhat confusing error about the missingbisect-rustcsubcommand. This also apples to--helpand-h.Fixes #359