WIP: Include lock file path in verbose mode output #15486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-filesystem
weihanglo
reviewed
May 5, 2025
| if try_acquire(path, lock_try)? { | ||
| return Ok(()); | ||
| } | ||
| let msg = format!("waiting for file lock on {}", msg); | ||
| let path = path.display(); | ||
| let msg = if verbose { |
There was a problem hiding this comment.
Unsure if the discoverability of this behind --verobse. Personally I am fine with just printing the lock path unconditionally, though I think per our contribution policy maybe we want to discuss this in the original issue #15094?
Gordon01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #15094
When Cargo is run with
--verbose, the message now includes the path to the lockfile it's waiting on. This makes it easier to debug situations where a stale or stuck lock is preventing progress, especially when no other Cargo process appears to be running.I've personally encountered this a few times.
How should we test and review this PR?
Run cargo with
--verboseand some kind of lock engaged.Previously, the message simply stated:
Now it includes the full path: