Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dep jobslot instead of jobserver #720

Closed
wants to merge 2 commits into from
Closed

Use dep jobslot instead of jobserver #720

wants to merge 2 commits into from

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Sep 9, 2022

What is jobslot?

jobslot is a fork of jobserver.

Advantages over jobserver?

  • jobslot contains bug fix for Client::configure is unsafe
  • jobslot removed use of signal handling in the helper thread on unix
  • jobslot uses winapi on windows instead of manually declaring bindings (some of the bindings seem to be wrong)
  • jobslot uses getrandom on windows instead of making homebrew one using raw windows api

Signed-off-by: Jiahao XU [email protected]

@NobodyXu NobodyXu closed this Nov 26, 2022
@NobodyXu NobodyXu deleted the use-jobslot branch November 26, 2022 07:26
@thomcc
Copy link
Member

thomcc commented Nov 26, 2022

Sorry, I never got around to reviewing this (as it also mostly required auditing jobslot).

@NobodyXu
Copy link
Collaborator Author

Sorry, I never got around to reviewing this (as it also mostly required auditing jobslot).

No worries, I can open it again if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants