Use criterion for benchmark
#609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to bump the minimum Rust version to 1.74 in Cargo.toml and in the CI configuration. Since Cargo now supports MSRV-aware resolution. |
ldm0
force-pushed
the
bench_criterion
branch
2 times, most recently
from
7d506e3 to
132d31e
Compare
|
@Amanieu done |
|
Personally, I've come to prefer divan, but it's not terribly important either way. |
Amanieu
reviewed
Apr 29, 2025
| @@ -82,7 +82,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: dtolnay/rust-toolchain@nightly | |||
| - uses: dtolnay/rust-toolchain@1.65.0 # MSRV | |||
| - uses: dtolnay/rust-toolchain@1.74.0 # MSRV | |||
There was a problem hiding this comment.
One of our dev-dependencies needs 1.81. We can just raise the MSRV: since the cargo resolver now takes this into account it will no longer break people's builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #243
Related to #4
Version of
rayonwas changed from^1.2to^1.3since it's required bycriterion.