Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in waitpid parameter name #4334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimmycathy
Copy link

@jimmycathy jimmycathy commented Mar 16, 2025

Description

Corrected parameter spelling from 'optons' to 'options' in waitpid declaration. This matches POSIX standard naming for the options parameter used to specify waitpid behavior flags like WNOHANG and WUNTRACED.

ref: https://pubs.opengroup.org/onlinepubs/9699919799/functions/waitpid.html

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a permalink to sources to the PR description for reference, otherwise lgtm.

@jimmycathy
Copy link
Author

Please add a permalink to sources to the PR description for reference, otherwise lgtm.

Thanks. Modified.

Please review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants