Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate __int128, __uint128, __int128_t, __uint128 #4343

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sanstzu
Copy link

@sanstzu sanstzu commented Mar 19, 2025

Description

Deprecates __int128, __uint128, __int128_t, __uint128_t and replace them with u128/i128 types, as per (#4340)

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

Some changes occurred in the Android module

cc @maurer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set the version to 0.2.172? We can backport the deprecation, 1.0 will just have the removal. You can also add back the changes to use i128/u128 internally, that is a non-breaking change.

Those two things and a squash, then lgtm!

@rustbot label +stable-nominated

@rustbot rustbot added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-author and removed S-waiting-on-review labels Mar 22, 2025
@sanstzu
Copy link
Author

sanstzu commented Mar 22, 2025

Could you set the version to 0.2.172? We can backport the deprecation, 1.0 will just have the removal. You can also add back the changes to use i128/u128 internally, that is a non-breaking change.

Those two things and a squash, then lgtm!

@rustbot label +stable-nominated

Thanks for the review Trevor! Squashed my commits already.

@tgross35
Copy link
Contributor

Ctest is being silly again... these fields might just need to be skipped in libc-test. I'll take a closer look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-android O-gnu O-linux O-macos O-musl O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants