-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate __int128
, __uint128
, __int128_t
, __uint128
#4343
base: main
Are you sure you want to change the base?
Conversation
Some changes occurred in the Android module cc @maurer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you set the version to 0.2.172? We can backport the deprecation, 1.0 will just have the removal. You can also add back the changes to use i128
/u128
internally, that is a non-breaking change.
Those two things and a squash, then lgtm!
@rustbot label +stable-nominated
… version 0.2.172
Thanks for the review Trevor! Squashed my commits already. |
Ctest is being silly again... these fields might just need to be skipped in libc-test. I'll take a closer look |
Description
Deprecates
__int128
,__uint128
,__int128_t
,__uint128_t
and replace them withu128
/i128
types, as per (#4340)Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI