TreeBorrows: Put accesses diagnostic parameters into a single struct #4740
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
| /// Diagnostics data about the current access and the location we are accessing. | ||
| /// Used to create history events and errors. | ||
| #[derive(Clone, Debug)] | ||
| pub struct DiagnosticsExtra { |
There was a problem hiding this comment.
Maybe it should be more something like AccessContext? It's just a bunch of metadata about the current access.
There was a problem hiding this comment.
I like to have "Diag(nostics)" in the name as that makes it purpose more clear.
| /// Used to create history events and errors. | ||
| #[derive(Clone, Debug)] | ||
| pub struct DiagnosticsExtra { | ||
| pub struct AccessDiagnostics { |
There was a problem hiding this comment.
I'm not a big fan of this name -- "diagnostic" is the term used in the Rust compiler for a fully computed warning/error output, and that's not what this is.
What about "DiagnosticInfo"?
This comment has been minimized.
This comment has been minimized.
royAmmerschuber
force-pushed
the
feature/refactor-diagnostics-struct
branch
from
ed383a4 to
c7203fb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| /// Not set on wildcard accesses. | ||
| pub accessed_info: Option<&'node NodeDebugInfo>, | ||
| /// Diagnostic data about the current access. | ||
| pub access_diagnostics: &'node DiagnosticInfo, |
There was a problem hiding this comment.
| pub access_diagnostics: &'node DiagnosticInfo, | |
| pub access_info: &'node DiagnosticInfo, |
Seems more consistent?
There was a problem hiding this comment.
accessed_info and access_info seems confusing
There was a problem hiding this comment.
Maybe rename accessed_info to accessed_node_info?
royAmmerschuber
force-pushed
the
feature/refactor-diagnostics-struct
branch
from
9f752c4 to
15e9ece
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
royAmmerschuber
force-pushed
the
feature/refactor-diagnostics-struct
branch
2 times, most recently
from
78cd3e0 to
8d59f87
Compare
RalfJung
force-pushed
the
feature/refactor-diagnostics-struct
branch
from
8d59f87 to
b7f7a8f
Compare
3 participants
All the
perform_accessfunctions take 5 parameters that are purely used for diagnostic purposes. This puts them all into a single struct and passes them by reference.