Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't emit implicit drop inlay hints for macro #19117

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix: don't emit implicit drop inlay hints for macro #19117

merged 2 commits into from
Feb 11, 2025
+24 −2

Conversation

gohome001
Copy link
Contributor

This PR try to fix #19100

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2025
ChayimFriedman2
ChayimFriedman2 requested changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we hide other types of inlay hints in macros, it seems reasonable to hide them here too.

Thanks!

crates/ide/src/inlay_hints/implicit_drop.rs Outdated Show resolved Hide resolved
@ChayimFriedman2
Copy link
Contributor

Also, can you squash the commits?

@gohome001 gohome001 force-pushed the implicit-drop-inlay-hints-bug branch from c5b8676 to 42f11d4 Compare February 11, 2025 07:27
ChayimFriedman2
ChayimFriedman2 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into rust-lang:master with commit 8aa4ae5 Feb 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit drop inlay hints bug
3 participants
@gohome001 @ChayimFriedman2 @rustbot