fix: Fix postfix completions inside macros #19129
Open
+64
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
commented
Feb 10, 2025
| @@ -284,15 +294,15 @@ fn escape_snippet_bits(text: &mut String) { | |||
| stdx::replace(text, '$', "\\$"); | |||
| } | |||
|
|
|||
| fn include_references(initial_element: &ast::Expr) -> (ast::Expr, ast::Expr) { | |||
| fn include_references(initial_element: &ast::Expr) -> (ast::Expr, String) { | |||
There was a problem hiding this comment.
I had to change this method so that the node we use will be derived from the Semantics.
Previously the receiver text was taken directly from the AST, which in macros is missing trivia, leading to corruption (or just unintended replacement of user code). Now we upmap the range, and extract the original file text in it.
ChayimFriedman2
force-pushed
the
snippet-macro
branch
from
62ad2ba to
d6f3ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the receiver text was taken directly from the AST, which in macros is missing trivia, leading to corruption (or just unintended replacement of user code).
Now we upmap the range, and extract the original file text in it.
Fixes #19069.